Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-11809: Add N806 and fix naming warnings #96

Merged
merged 3 commits into from
Sep 6, 2017
Merged

DM-11809: Add N806 and fix naming warnings #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36b436b
Add N806 and move W503 to per file entry
timj Sep 6, 2017
de93104
Ignore a naming warning
timj Sep 6, 2017
c725254
Name test classes using proper convention
timj Sep 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/lsst/meas/base/measurementInvestigationLib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

from lsst.afw.table import SourceCatalog
from lsst.meas.base import NoiseReplacer, NoiseReplacerConfig
from lsst.meas.base import SingleFrameMeasurementTask as SFMT
from lsst.meas.base import SingleFrameMeasurementTask as SFMT # noqa N814


def rebuildNoiseReplacer(exposure, measCat):
Expand Down
6 changes: 4 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
[flake8]
max-line-length = 110
ignore = E133, E226, E228, N802, N803, W503
ignore = E133, E226, E228, N802, N803, N806
exclude = __init__.py, tests/testLib.py

[tool:pytest]
addopts = --flake8
flake8-ignore = E133 E226 E228 N802 N803 W503
flake8-ignore = E133 E226 E228 N802 N803 N806
# This will go away for newer flake8 versions
forcedPhotCoadd.py W503
# These will not be needed when we use numpydoc
baseMeasurement.py E266
forcedMeasurement.py E266
Expand Down
4 changes: 2 additions & 2 deletions tests/test_ApertureFlux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def testForcedPlugin(self):
class ApertureFluxTransformTestCase(FluxTransformTestCase, SingleFramePluginTransformSetupHelper,
lsst.utils.tests.TestCase):

class circApFluxAlgorithmFactory(object):
class CircApFluxAlgorithmFactory(object):
"""
Helper class to sub in an empty PropertyList as the final argument to
CircularApertureFluxAlgorithm.
Expand All @@ -261,7 +261,7 @@ def __call__(self, control, name, inputSchema):
lsst.daf.base.PropertyList())

controlClass = lsst.meas.base.ApertureFluxAlgorithm.Control
algorithmClass = circApFluxAlgorithmFactory()
algorithmClass = CircApFluxAlgorithmFactory()
transformClass = lsst.meas.base.ApertureFluxTransform
flagNames = ('flag', 'flag_apertureTruncated', 'flag_sincCoeffsTruncated')
singleFramePlugins = ('base_CircularApertureFlux',)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_ShapeUtilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import lsst.utils.tests


class shapeTransformMatrixTestCase(lsst.utils.tests.TestCase):
class ShapeTransformMatrixTestCase(lsst.utils.tests.TestCase):

def testIdentity(self):
# A no-op coordinate transform translates to a no-op shape transform
Expand Down
2 changes: 1 addition & 1 deletion tests/test_SincPhotSums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def plantSources(bbox, kwid, sky, coordList, addPoissonNoise=True):
return exposure


class sincPhotSums(lsst.utils.tests.TestCase):
class SincPhotSums(lsst.utils.tests.TestCase):

def setUp(self):
self.nx = 64
Expand Down