Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-12243: make inputCount more robust #99

Merged
merged 6 commits into from
Nov 8, 2017
Merged

DM-12243: make inputCount more robust #99

merged 6 commits into from
Nov 8, 2017

Commits on Nov 7, 2017

  1. add input count to forced coadd measurement 

    Having it only in unforced measurement isn't as helpful because it can be
skipped if the centroid is flagged, leaving us without a count measurement.
    @PaulPrice
    PaulPrice committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    7b0f003 View commit details
    Browse the repository at this point in the history

  2. inputCount: only fail if the centroid is actually bad 

    Even if the centroid has been declared to be bad (through the flag), still
attempt to measure the number of inputs at the position, as this might
provide something useful.
    @PaulPrice
    PaulPrice committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    ad055e7 View commit details
    Browse the repository at this point in the history

  3. add standard __future__ imports

    @PaulPrice
    PaulPrice committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    9dbc7db View commit details
    Browse the repository at this point in the history

  4. wrappers: add factories to produce SFM/forced plugins from generic 

    Some measurement plugins are really generic in the sense that it
doesn't matter whether they are run as a single-frame or forced
plugin, but the plumbing is slightly different (most notably, the
signature of the 'measure' method). To work around this, added a
GenericPlugin class and methods that will use that to produce the
appropriate SingleFramePlugin and ForcedPlugin classes so common
code can be used for both.
    @PaulPrice
    PaulPrice committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    15a1067 View commit details
    Browse the repository at this point in the history

  5. plugins: convert variance and inputCount plugins to generic 

    These previously only worked in single-frame measurement, but they would
be useful in forced measurement too. Using the new GenericPlugin, we can
use the same code to achieve both. This necessitated some small changes in
the error handling.
    @PaulPrice
    PaulPrice committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    099eb53 View commit details
    Browse the repository at this point in the history

  6. add variance measurement to forced coadd measurement

    @PaulPrice
    PaulPrice committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    c2f11c2 View commit details
    Browse the repository at this point in the history