DM-7347: Pytest updates #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that had been named in conflict with teh test naming convention have been renamed to be in compliance. The gitignore has been updated to ignore the doc/xml folder.
The tests in meas_deblender have been modernized to be runnable under the py.test framework and have been autoformatted using autopep8 to be compliant with the LSST PEP8 framework. All usage of depracted assertions has been updated.
| import pylab as plt | ||
| import os.path | ||
| plotpat = os.path.join(os.path.dirname(__file__), 'edge%i.png') | ||
| print 'Writing plots to', plotpat |
There was a problem hiding this comment.
It's not entirely clear how to handle these lines (and the similar lines in the other file). I guess we leave it as is for now until we can work out how doPlot ever becomes true when we are running in py.test. We could put this code in a setupClass method and trigger with an environment variable but ignore it for now. Please file a ticket for revisiting the plotting in the test code in meas_deblender. I think that's what @jdswinbank would prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.