Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-7886: Use astropy rather than pyfits #55

Merged
merged 1 commit into from Jul 11, 2018
Merged

Conversation

timj
Copy link
Member

@timj timj commented Jul 6, 2018

No description provided.

@timj timj requested a review from r-owen July 6, 2018 21:50
@timj timj changed the title Use astropy rather than pyfits DM-7886: Use astropy rather than pyfits Jul 6, 2018
Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but consider adding astropy to the ups table file

@timj timj force-pushed the tickets/DM-7886-deblender branch from f7cdca4 to af782f2 Compare July 10, 2018 20:49
@timj
Copy link
Member Author

timj commented Jul 11, 2018

I don't think I should add astropy as a dependency solely for code examples.

@timj timj force-pushed the tickets/DM-7886-deblender branch from af782f2 to 231789a Compare July 11, 2018 21:11
@timj timj merged commit 231789a into master Jul 11, 2018
@r-owen
Copy link
Contributor

r-owen commented Jul 11, 2018

Not even as an optional dependency? I usually use optional dependencies for code only used by examples.

@ktlim ktlim deleted the tickets/DM-7886-deblender branch August 25, 2018 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants