DM-14828: Update pybind11 wrappers for 2.2 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class name needlessly exposed internal details of afw and was no longer correct due to recent changes in afw. The shorter, preferred name, should be valid for the long term.
natelust
approved these changes
Jul 20, 2018
| @@ -1175,7 +1175,7 @@ def skipParent(self, source, masks): | |||
| ---------- | |||
| source: `lsst.afw.table.source.source.SourceRecord` | |||
| The source to flag as skipped | |||
| masks: list of `lsst.afw.image.mask.mask.MaskX` | |||
| masks: list of `lsst.afw.image.MaskX` | |||
There was a problem hiding this comment.
This maybe could be updated to just say Mask, as the Mask constructor will resolve to MaskX. It was designed so people would not need to know the details of the mask extension. However, as the concrete type is MaskX it would be appropriate to leave it as you have it as well.
|
I don't know the current Python mask types so I just went with it -- I figured it was safer to leave well enough alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.