DM-15442: Add missing pyList=[] to test/SConscript files #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in scons and github Travis
r-owen
force-pushed
the
tickets/DM-15442
branch
from
d285e1d
to
4cd9210
Compare
|
I've turned on Travis. |
timj
approved these changes
Aug 16, 2018
| @@ -69,15 +65,15 @@ def run(visit, rerun, config): | |||
| psf = butler.get('psf', dataId) | |||
| print('PSF:', psf) | |||
|
|
|||
| testDeblend(foots, pks, mi, psf) | |||
| # testDeblend(foots, pks, mi, psf) | |||
There was a problem hiding this comment.
Why is the code to test the deblender commented out?
examples/utils.py
Outdated
|
|
||
| class _mockSource(object): | ||
| class _MockSource(object): |
There was a problem hiding this comment.
Could in theory remove (object) here and elsewhere.
| from builtins import zip | ||
| from builtins import str | ||
| from builtins import range | ||
| from builtins import object | ||
| #!/usr/bin/env python |
There was a problem hiding this comment.
Agreed. I also found and removed it in some other library and test files.
| @@ -276,7 +279,7 @@ def deblend(self, exposure, srcs, psf): | |||
| n0 = len(srcs) | |||
| nparents = 0 | |||
| for i, src in enumerate(srcs): | |||
| #t0 = time.clock() | |||
| # t0 = time.clock() | |||
There was a problem hiding this comment.
time.clock() is deprecated so it's debatable whether this code should be here at all. See DM-15450
There was a problem hiding this comment.
Thanks for catching this. I suggest we fix it on DM-15450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and stop using python 2 and enable automatic flake8 checking