Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-16179: Change log level to WARN for the footprint skipping #69

Merged
merged 1 commit into from Jul 16, 2019

Conversation

laurenam
Copy link
Contributor

Skipping of footprints in the deblender is a useful and important piece
of processing information, so should be set to WARN (instead of TRACE)
so that it will be logged with default logging settings.

Skipping of footprints in the deblender is a useful and important piece
of processing information, so should be set to WARN (instead of TRACE)
so that it will be logged with default logging settings.
Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
Just outta curiousity, why is the code duplicated?

@laurenam
Copy link
Contributor Author

I believe that is a question for @fred3m (and his Multiband tasks) :)

@fred3m
Copy link
Contributor

fred3m commented Jul 16, 2019

Two different classes, SourceDeblendTask and MultibandDeblendTask. There are a few small code blocks that are nearly identical but not enough to warrant having a base class, especially since we expected to change MultibandDeblendTask. As it turns out we changed it so much that we just made a new package meas_extensions_scarlet.

@laurenam laurenam merged commit 4ea6b3d into master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants