Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-20566: Replace afwGeom with geom #70

Merged
merged 2 commits into from Jul 18, 2019
Merged

DM-20566: Replace afwGeom with geom #70

merged 2 commits into from Jul 18, 2019

Conversation

timj
Copy link
Member

@timj timj commented Jul 18, 2019

No description provided.

@timj timj requested review from fred3m and isullivan July 18, 2019 17:26
isullivan
isullivan approved these changes Jul 18, 2019
View reviewed changes
Copy link

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. afwGeom.SpanSet seems to me like it should also belong in geom, but that should probably be done on a new ticket.

@timj
Copy link
Member Author

timj commented Jul 18, 2019

I am entirely unclear why SpanSet is not in geom but I assume @TallJimbo had his reasons 😄

I'm definitely not tackling a SpanSet move on this ticket.

@timj timj merged commit df0b915 into master Jul 18, 2019
@timj timj deleted the tickets/DM-20566-meas_deblender branch July 18, 2019 21:30
@TallJimbo
Copy link
Member

SpanSet depends on afw::table for serialization. Polygon can't move for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

@fred3m fred3m Awaiting requested review from fred3m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@timj @TallJimbo @isullivan