DM-6999: Logging framework migration #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2016 12:00
Based on 6428a77 - replace pex.logging logdebug using lsst.log.Log TRACE level - replace pex.logging at -9 using lsst.log.Log DEBUG level
hsinfang
force-pushed
the
tickets/DM-6999
branch
from
48fe2d3
to
5c242c2
Compare
| @@ -207,7 +207,7 @@ def addSchemaKeys(self, schema): | |||
| 'deblend_hasStrayFlux', type='Flag', | |||
| doc=('This source was assigned some stray flux')) | |||
|
|
|||
| self.log.logdebug('Added keys to schema: %s' % ", ".join(str(x) for x in ( | |||
| self.log.trace('Added keys to schema: %s', ", ".join(str(x) for x in ( | |||
| self.nChildKey, self.psfKey, self.psfCenterKey, self.psfFluxKey, | |||
There was a problem hiding this comment.
Why the change in level from debug to trace?
There was a problem hiding this comment.
It was discussed previously here (and noted in the commit message). For this logger named "meas_deblender.baseline", two tracing levels are currently used in master: a less verbose log.log(-9, ...) and a more verbose log.logdebug(...). So the former maps to log.debug() and the latter maps to log.trace() in the conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.