DM-35552: Throw better error message for PSF shape fails #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
tickets/DM-35552
branch
from
9f0cd3c
to
cc4bbbe
Compare
arunkannawadi
commented
Oct 13, 2022
| continue | ||
| else: | ||
| raise ValueError(f"PSF at {center} has an invalid FWHM value of {psf_fwhm}") | ||
|
|
||
| self.log.trace('Parent %i: deblending %i peaks', int(src.getId()), len(pks)) | ||
|
|
||
| self.preSingleDeblendHook(exposure, srcs, i, fp, psf, psf_fwhm, sigma1) |
There was a problem hiding this comment.
I don't know what this is meant for, but I wonder if this should be the place to catch this and throw an error? But I'm not sure how to continue onto the next source if self.cofig.catchFailures is True.
There was a problem hiding this comment.
I'm not sure what that was meant for either. I guess at some point in the distant past someone thought that it would be used for something that was never implemented.
fred3m
approved these changes
Oct 13, 2022
| continue | ||
| else: | ||
| raise ValueError(f"PSF at {center} has an invalid FWHM value of {psf_fwhm}") | ||
|
|
||
| self.log.trace('Parent %i: deblending %i peaks', int(src.getId()), len(pks)) | ||
|
|
||
| self.preSingleDeblendHook(exposure, srcs, i, fp, psf, psf_fwhm, sigma1) |
There was a problem hiding this comment.
I'm not sure what that was meant for either. I guess at some point in the distant past someone thought that it would be used for something that was never implemented.
and throw a better error message.
arunkannawadi
force-pushed
the
tickets/DM-35552
branch
from
cc4bbbe
to
160a994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.