DM-42999: Demote routine "warnings" to less alarming log levels #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are always large footprints (e.g. satellite trails) and there are always heavily-flagged sources (e.g., sources in the edge region). The main reason a log would be interesting is for tracing back when a given source was thrown out, so set to debug.
parejkoj
reviewed
Feb 29, 2024
| @@ -353,14 +353,14 @@ def deblend(self, exposure, srcs, psf): | |||
| if self.isLargeFootprint(fp): | |||
| src.set(self.tooBigKey, True) | |||
| self.skipParent(src, mi.getMask()) | |||
| self.log.warning('Parent %i: skipping large footprint (area: %i)', | |||
| int(src.getId()), int(fp.getArea())) | |||
| self.log.debug('Parent %i: skipping large footprint (area: %i)', | |||
There was a problem hiding this comment.
I think I'd lean on this one being info level, since this is a bit more of a "something is wrong" skip.
There was a problem hiding this comment.
Something isn't wrong -- per the docs for isLargeFootprint, it's supposed to flag things like satellite streaks. (And if it were a problem, warning, not info, would be an appropriate level.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demotes
warninglogs issued whenever a source has mask flags or is trailed todebug.