wrap ConvolvedFluxPlugin to allow use in forced measurement #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the ConvolvedFluxPlugin class into a base class that we then wrap with the appropriate plugin base class. There's also a little bit of fiddling required to give the forced measurement a slightly different signature. In order to do the forced measurement, we need to add transformation from the reference frame to the measurement frame. Since we're already doing forced measurement (center is provided, aperture shape and radius are provided), moved the calculation into a 'measureForced' method, and have 'measure' call that with a null transformation. Modified the test to check that forced measurement also works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the ConvolvedFluxPlugin class into a base class that we then
wrap with the appropriate plugin base class. There's also a little
bit of fiddling required to give the forced measurement a slightly
different signature.
In order to do the forced measurement, we need to add transformation
from the reference frame to the measurement frame. Since we're
already doing forced measurement (center is provided, aperture shape
and radius are provided), moved the calculation into a 'measureForced'
method, and have 'measure' call that with a null transformation.
Modified the test to check that forced measurement also works.