Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-31062: Use the plugin name by default #15

Merged
merged 1 commit into from Jul 10, 2021
Merged

Conversation

arunkannawadi
Copy link
Member

When generating the list of GAaP fields, use the plugin name as the
prefix by default instead of generating only the middle strings.

When generating the list of GAaP fields, use the plugin name as the
prefix by default instead of generating only the middle strings.
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@arunkannawadi
Copy link
Member Author

arunkannawadi commented Jul 9, 2021

The non-user-facing method _getGaapResultName still has None as it's default, as that option is used quite often. Only the default for the user-facing method getAllGaapResultNames is changed.

@arunkannawadi arunkannawadi merged commit 26e77d7 into master Jul 10, 2021
@arunkannawadi arunkannawadi deleted the tickets/DM-31062 branch August 16, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants