DM-31060: Clean up some log message usage #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsst.log supports both but logging prefers warning.
The latter is not supported by python logging.
arunkannawadi
commented
Jul 16, 2021
| @@ -328,7 +328,7 @@ def _solve(self, kernelCellSet, basisList): | |||
| spatialSolution = spatialkv.getKernelSolution() | |||
| except Exception as e: | |||
| self.log.error("ERROR: Unable to calculate psf matching kernel") | |||
| log.log("TRACE1." + self.log.getName() + "._solve", log.DEBUG, str(e)) | |||
| log.log("TRACE1." + self.log.name + "._solve", log.DEBUG, str(e)) | |||
There was a problem hiding this comment.
Is this way of string concatenation fine?
There was a problem hiding this comment.
It is what is used in other place. The alternative would be:
log.log(f"TRACE1.{self.log.name}._solve", log.DEBUG, str(e))or an alternative approach that might be more consistent with how other messages are logged:
log.getLogger(f"TRACE1.{self.log.name}._solve").debug("%s", e)There was a problem hiding this comment.
I incorporated the second approach. The unit tests pass. Can I merge it without running Jenkins again? I'm not even sure if this line ever gets triggered anyway.
timj
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.