Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40463: Fix the failing test on macOS Ventura 13.5 #32

Merged
merged 3 commits into from Aug 23, 2023

Conversation

arunkannawadi
Copy link
Member

No description provided.

@arunkannawadi arunkannawadi force-pushed the tickets/DM-40463 branch 2 times, most recently from 53c7931 to 4ef11ee Compare August 23, 2023 00:54
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I wonder if

if sigma <= targetSigma * wcs.getPixelScale(center).asArcseconds():
needs an epsilon as well, or is this all okay as is?

@arunkannawadi
Copy link
Member Author

It should be okay! Measurement failure can happen even if they are off by a much larger amount, say 1e-2 but such close encounters are going to be rare in practice. The main flag would be set indicating a failure regardless. We just set a more informative flag only if satisfies this condition.

@arunkannawadi arunkannawadi merged commit 8dd6597 into main Aug 23, 2023
2 checks passed
@arunkannawadi arunkannawadi deleted the tickets/DM-40463 branch August 23, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants