Update source to use new Footprint API #19
Conversation
| @@ -265,7 +257,8 @@ PTR(KronAperture) KronAperture::determineRadius( | |||
| // | |||
| // Build an elliptical Footprint of the proper size | |||
| // | |||
| afw::detection::Footprint foot(afw::geom::ellipses::Ellipse(axes, center)); | |||
| afw::detection::Footprint foot(afw::geom::SpanSet::fromShape( | |||
| afw::geom::ellipses::Ellipse(axes, center))); | |||
There was a problem hiding this comment.
To make my comments from previous pull requests more general, I think that one should be able to initialize a Footprint with any object that can be used to initialize a SpanSet. There doesn't appear to be a good reason to me to break the old (and more convenient) API, especially with the new 80 char limit for python code.
There was a problem hiding this comment.
A note here, we have discussed this a bit in person, but a note here for posterity. The API for footprint was chosen to only take a shared pointer to a SpanSet such that 1. Code duplication was minimized (maintaining two similar parallel apis) 2. To encourage developers to used a SpanSet instead of a footprint whenever possible. These two things were weighted against verbosity, and ultimately we decided against verbosity of code
| @@ -282,7 +275,8 @@ PTR(KronAperture) KronAperture::determineRadius( | |||
| ); | |||
|
|
|||
| try { | |||
| iRFunctor.apply(foot); | |||
| foot.getSpans()->applyFunctor( | |||
| iRFunctor, *(subImage.getImage())); | |||
There was a problem hiding this comment.
Could an applyTo method be added to FootprintFindMoment to mimick the old functionality? This feels unnecessarily clunky.
No description provided.