Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34584: Use samplingSize in setting stamp size #10

Merged
merged 1 commit into from May 24, 2022
Merged

DM-34584: Use samplingSize in setting stamp size #10

merged 1 commit into from May 24, 2022

Conversation

arunkannawadi
Copy link
Member

No description provided.

@arunkannawadi
Copy link
Member Author

@jmeyers314 Are these the only fixes required to get the samplingSize config right?

@arunkannawadi arunkannawadi marked this pull request as ready for review May 16, 2022 16:53
@jmeyers314
Copy link
Collaborator

I think you need to add something to the _validatePsfCandidates method too.

@jmeyers314
Copy link
Collaborator

Other than that, looks good to me.

@arunkannawadi
Copy link
Member Author

@jmeyers314 I added the changes to _validatePsfCandidate method and improved the tests to include samplingSize parameter as well. One thing I'm confused about is whether we should be dividing or multiplying by the samplingSize parameter. Note that samplingSize=0.5 should correspond to 2x oversampling. If I remember right, you had multiplication in your local repo.

jmeyers314
jmeyers314 approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@jmeyers314 jmeyers314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arunkannawadi arunkannawadi merged commit c3b167f into main May 24, 2022
@arunkannawadi arunkannawadi deleted the tickets/DM-34584 branch May 24, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeyers314 jmeyers314 jmeyers314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arunkannawadi @jmeyers314