DM-36071: Deprecate kernelSize and switch to stampSize #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
tickets/DM-36071
branch
2 times, most recently
from
5cdd30a
to
a1c11f4
Compare
TallJimbo
approved these changes
Oct 12, 2022
tests/test_psf.py
Outdated
| @@ -360,6 +365,27 @@ def testValidateGalsimInterpolant(self): | |||
| self.assertTrue(_validateGalsimInterpolant(f"galsim.{interp}")) | |||
| self.assertTrue(eval(f"galsim.{interp}")) | |||
|
|
|||
| def testKernelSize(self): # TODO: Remove this test in DM-36311. | |||
| warnings.filterwarnings("ignore", category=FutureWarning) | |||
There was a problem hiding this comment.
I think you can do with with a with self.assertWarns: block, which will both check that the warning appears and make sure the warnings filter is disabled properly at the end.
arunkannawadi
force-pushed
the
tickets/DM-36071
branch
3 times, most recently
from
59e90d4
to
d4382c5
Compare
arunkannawadi
force-pushed
the
tickets/DM-36071
branch
from
d4382c5
to
2f6b1d6
Compare
arunkannawadi
force-pushed
the
tickets/DM-36071
branch
from
2f6b1d6
to
7cba5f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.