DM-36998: Remove large objects from Piff results by default #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeyers314
changed the title
yalsayyad
approved these changes
Nov 15, 2022
| @@ -105,6 +105,10 @@ class PiffPsfDeterminerConfig(BasePsfDeterminerTask.ConfigClass): | |||
| check=_validateGalsimInterpolant, | |||
| default="Lanczos(11)", | |||
| ) | |||
| _debugStarData = pexConfig.Field[bool]( | |||
There was a problem hiding this comment.
I have a strong preference for not making private configs a new thing in the stack. debugStarData would be fine.
| @@ -105,6 +105,10 @@ class PiffPsfDeterminerConfig(BasePsfDeterminerTask.ConfigClass): | |||
| check=_validateGalsimInterpolant, | |||
| default="Lanczos(11)", | |||
| ) | |||
| _debugStarData = pexConfig.Field[bool]( | |||
| doc="Write used star image data to disk for debugging.", | |||
There was a problem hiding this comment.
thought PsfDeterminer doesn't necessarily interact with a disk, so this is really more like "Include star images used for fitting in the PSF model/object"
jmeyers314
force-pushed
the
tickets/DM-36998
branch
from
f4777f3
to
c5c553e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.