DM-43885: Add down-sampling of stars for PiffPsfDeterminer when we have more than we need. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Apr 13, 2024
| @@ -219,6 +220,8 @@ def setupDeterminer( | |||
| psfDeterminerConfig.stampSize = stampSize | |||
| psfDeterminerConfig.debugStarData = debugStarData | |||
| psfDeterminerConfig.useCoordinates = useCoordinates | |||
| if downsample: | |||
| psfDeterminerConfig.maxCandidates = 10 | |||
There was a problem hiding this comment.
I'd have imagined passing maxCandidates as the optional argument instead of downsample. Is this choice because chiLim value below depends on maxCandidates?
There was a problem hiding this comment.
I just wanted to be clear what codepath was being tested. It's somewhat arbitrary.
erykoff
force-pushed
the
tickets/DM-43885
branch
from
60c11eb
to
6e3fc72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.