tickets/DM-27208 #28
Merged
tickets/DM-27208 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 20, 2020 16:00
At some point we stopped using the mask plane for weights and started just using the inverse variance. There is some disagreement over whether or not this is the right thing to do, and testing with scarlet has shown including weights tends to produce worse results. So this commit reintroduces the mask plane weights and makes that the default configuration.
taranu
approved these changes
Nov 2, 2020
taranu
reviewed
Nov 2, 2020
| @@ -592,10 +596,16 @@ def deblend(self, mExposure, sources): | |||
| self._skipParent(src, mask) | |||
| self.log.trace('Parent %i: skipping masked footprint', int(src.getId())) | |||
| continue | |||
| if len(peaks) > self.config.maxNumberOfPeaks: | |||
| if self.config.maxNumberOfPeaks > 0 and len(peaks) > self.config.maxNumberOfPeaks: | |||
There was a problem hiding this comment.
It doesn't particularly matter much but you could store this value before the loop rather than checking every time, or simply set maxNumberOfPeaks to np.inf if it's zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add columns to make it easier to cross check meas_deblender and meas_extensions_scarlet.