DM-28542: Implement RFC-750 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
force-pushed
the
tickets/DM-28542
branch
from
8ed5aff
to
0011b06
Compare
added 2 commits
March 2, 2021 12:44
The deblend_parentNPeaks column was never updated, and there was no deblend_parentNChild column to keep track of the number of children actually deblended from a parent. So this commit fixes those erroneous columns
laurenam
reviewed
Mar 11, 2021
|
In principle, this PR should be titled (https://developer.lsst.io/work/flow.html#make-a-pull-request): |
laurenam
approved these changes
Mar 14, 2021
fred3m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deblend_parentNPeaks column was never updated, and there was no deblend_parentNChild column to keep track of the number of children actually deblended from a parent. So this PR fixes those erroneous columns.