DM-28730: Turn off setSpectra initialization by default #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For large skinny blends the `setSpectra` method of initialization causes the initialization to run out of memory, so by default we turn this option off. DM-28870 will investigate if there is a criteria (such as peaks*bands*area) that we can use to determine when it is safe to use setSpectra and when to skip that step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large skinny blends the
setSpectramethod of initializationcauses the initialization to run out of memory, so by default we
turn this option off. DM-28870 will investigate if there is a
criteria (such as peaksbandsarea) that we can use to determine
when it is safe to use setSpectra and when to skip that step.