DM-28947: Add option to optionally set spectra init #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
approved these changes
Feb 24, 2021
| else: | ||
| spectrumInit = len(centers) * bbox.getArea() < config.maxSpectrumCutoff | ||
| else: | ||
| spectrumInit = config.setSpectra |
There was a problem hiding this comment.
I think in this case this is always False, right? I think it should just be set to False.
There was a problem hiding this comment.
Yes. Originally I tried to use True to always use setSpectra, False to never use it, and None to check maxSpectrumCutoff, but the stack won't let me use None as the default for a bool (which makes sense, but :( ).
fred3m
force-pushed
the
tickets/DM-28947
branch
from
19a4a62
to
b34558f
Compare
|
One more thing: the title of the PR has a typo. |
fred3m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.