Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34777: Remove option for a null position in _computePsfImage #52

Merged
merged 2 commits into from May 12, 2022
Merged

DM-34777: Remove option for a null position in _computePsfImage #52

merged 2 commits into from May 12, 2022

Conversation

fred3m
Copy link
Contributor

@fred3m fred3m commented May 12, 2022

No description provided.

@erykoff
Copy link
Contributor

erykoff commented May 12, 2022

Title of PR needs the ticket number.

@fred3m fred3m changed the title Remove option for a null position in _computePsfImage DM-34777: Remove option for a null position in _computePsfImage May 12, 2022
@arunkannawadi arunkannawadi self-requested a review May 12, 2022 18:46
arunkannawadi
arunkannawadi approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@arunkannawadi arunkannawadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think it's better for this PR to remove the unused _getPsfFwhm method, and have my other PR closed without merging.

@arunkannawadi arunkannawadi mentioned this pull request May 12, 2022
Closed
@fred3m fred3m merged commit c6e6cc1 into main May 12, 2022
@fred3m fred3m deleted the tickets/DM-34777 branch May 12, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunkannawadi arunkannawadi arunkannawadi approved these changes

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fred3m @erykoff @arunkannawadi