DM-33710: store scarlet models in place of footprints #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Jun 2, 2022
TallJimbo
approved these changes
Jun 8, 2022
| if updateFluxColumns: | ||
| # Set the flux of the scarlet model | ||
| # TODO: this field should probably be deprecated, | ||
| # since DM-33710 gives users access to the scarlet models. |
There was a problem hiding this comment.
If it's coming from a config field, yes, that would need an RFC. If it's just some function argument, then I think probably not unless it's prominent in some task. Boundary between public and [package-]private interfaces here is a little blurry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.