DM-35530: Fix typo in persisted scarlet model data #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
approved these changes
Jul 12, 2022
| @@ -130,7 +130,7 @@ def asDict(self) -> dict: | |||
| return { | |||
| "xy0": self.xy0, | |||
| "extent": self.extent, | |||
| "center": self.extent, | |||
| "center": self.center, | |||
There was a problem hiding this comment.
Because of the mix-n’-match of conventions, it wouldn’t hurt to be explicit about (y, x) vs. (x, y) in the variable doc strings (in addition to your comment in the class description above). I got nervous looking at your test…!
There was a problem hiding this comment.
Good point, I'll make it clear in the docs.
There was a problem hiding this comment.
It's actually more confusing than you think. To be consistent with xy0 and the rest of the stack, the center in the persistence model is in (x, y) format, it's just scarlet that uses the C++ (y, x) format. But I am clarifying in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.