DM-35722: Catch errors in setting the HeavyFootprint peak flux #59
Conversation
| srcId = sourceRecord.getId() | ||
| x = peak["i_x"] | ||
| y = peak["i_y"] | ||
| warnings.warn(f"Source {srcId} at {x},{y} could not set the peak flux with error:") |
There was a problem hiding this comment.
Would it make more sense to use LSST's logging rather than warnings?
There was a problem hiding this comment.
I agree this looks more like a log.warning() -- warnings to get converted to log messages but they won't be found as easily because the wrong logger will be used.
There was a problem hiding this comment.
Does it work to import the logger using
import logging
logger = logging.getLogger("lsst.meas.extensions.scarlet")
logger.warning("Log message here")
or do I have to pass it the logger from a task?
There was a problem hiding this comment.
I thought measurement plugins had access to a logger so does logging.getLogger(self.logName) work to get the logger? That seems to work in some meas_extensions packages.
If that doesn't work use logger = logging.getLogger(__name__) so you don't have to hard code the full name in there.
fred3m
force-pushed
the
tickets/DM-35722
branch
from
b7c473a
to
e311309
Compare
| x = peak["i_x"] | ||
| y = peak["i_y"] | ||
| logger.warn(f"Source {srcId} at {x},{y} could not set the peak flux with error:") | ||
| traceback.print_exc() |
There was a problem hiding this comment.
This should not be called because it won't go to the logging system and we can't tell where it will turn up. Instead you should use logger.exception() and that would print your log message above and also include the exception traceback.
No description provided.