DM-38432: Implement scarlet_lite stand alone package #70
Conversation
fred3m
force-pushed
the
tickets/DM-38432
branch
from
2ecb4a5
to
cd9c6c0
Compare
| totalBands = len(spectrum.x) | ||
| morph = FixedParameter(factorizdedData.morph) | ||
| factorized = FactorizedComponent( | ||
| bands=("dummy", ) * totalBands, |
There was a problem hiding this comment.
Is it surprising that the band name not matching "band" above didn't cause any problems, or are band names just labels that get ignored assuming that users keep bands in a consistent order?
There was a problem hiding this comment.
The labels are meaningless when the model is only used in a single band. We only care about the band names if we are looking at the full multiband models.
| modelData: scl.io.ScarletModelData, | ||
| catalog: SourceCatalog, | ||
| band: str, | ||
| redistributeImage: afwImage | None = None, |
There was a problem hiding this comment.
This kind of sounds more like a boolean arg. Maybe redistributingImage instead?
There was a problem hiding this comment.
Changed to imageForRedistribution.
| Returns | ||
| ------- | ||
| heavy: | ||
| The footprint (possibly multiband) containing the model for the source. |
There was a problem hiding this comment.
Is MultibandFootprint actually a HeavyFootprintF? If not, the return value type hint should be updated.
There was a problem hiding this comment.
It can be either one, thanks for pointing this out. I updated the docstring and type hint.
| self.assertEqual(config.version, "lite") | ||
|
|
||
| # Check that the PSF and other properties are the same | ||
| assert_almost_equal(oldModelData.psf, modelData.psf) |
There was a problem hiding this comment.
Are you expecting machine epsilon level differences or larger ones (in which case this might be too sensitive of a check)?
There was a problem hiding this comment.
These should be identical, but I made them machine level just to be safe.
| self.assertTupleEqual(oldBlendData.shape, blendData.shape) | ||
| self.assertTupleEqual(oldBlendData.psf_center, blendData.psf_center) | ||
| self.assertTupleEqual(tuple(oldBlendData.sources.keys()), tuple(blendData.sources.keys())) | ||
| assert_almost_equal(oldBlendData.psf, blendData.psf) |
There was a problem hiding this comment.
This is the PSF per blend, which is different from the oldModelData.psf above, right?
There was a problem hiding this comment.
Yes. oldModelData.psf and modelData.psf is the model PSF that all of the blends are generated in.
fred3m
force-pushed
the
tickets/DM-38432
branch
2 times, most recently
from
ca0b4c6
to
a5fdf76
Compare
fred3m
force-pushed
the
tickets/DM-38432
branch
from
a5fdf76
to
f50617d
Compare
No description provided.