DM-40451: Allow deblending to continue even when data is missing for some bands #72
Conversation
fred3m
changed the title
Previously any footprints that could not construct a PSF in all bands were skipped. As part of HSC PDR4, because there are patches with only partial coverage of narrow bands (for example), we want to allow the deblender to proceed. This ticket implements deblending with only partial PSF coverage, and also adds new columns to the catalog to keep track of the coverage per band.
fred3m
force-pushed
the
tickets/DM-40451
branch
from
023ee99
to
ede0ed8
Compare
|
|
||
| try: | ||
| psfModels = mExposure.computePsfKernelImage(psfCenter) | ||
| except IncompleteDataError as e: |
There was a problem hiding this comment.
My general feeling is that try-excepts should be avoided as much as possible. Since you are already changing the parameters and returned values in computePsfKernelImage, you could consider adding something like an allowMissing option, then always returning the psfs and the filters used. I'm not sure if that would be simpler.
There was a problem hiding this comment.
I think this is a good example of a case where it is easier to ask forgiveness than acceptance. I originally used an allowMissing parameter but it requires an additional check by the user to see if any bands were missing. Since this check is already being done while creating the PSF image I wanted to find a way to avoid having to validate the output again, and this seemed like a good way to ensure that users who don't expect a bad PSF will get an error, and users who know that it might happen do not have to check for it.
…dels Because deepCoadd_forced does not require the imageMask to set the coverage column (which instead is in the meas catalog), this ticket makes that parameter optional.
Previously any footprints that could not construct a PSF in all bands were skipped. As part of HSC PDR4, because there are patches with only partial coverage of narrow bands (for example), we want to allow the deblender to proceed.
This ticket implements deblending with only partial PSF coverage, and also adds new columns to the catalog to keep track of the coverage per band.