DM-43176: Flag sources with no flux after re-distribution. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
force-pushed
the
tickets/DM-43176
branch
3 times, most recently
from
e6fcb33
to
6fb301e
Compare
TallJimbo
approved these changes
Mar 12, 2024
| footprint = afwFootprint(SpanSet(spanList)) | ||
| footprint.setPeakCatalog(heavy.peaks) | ||
| zeroImage = afwImage(array=np.array([[0]], dtype=np.float32), xy0=center, dtype=dtype) | ||
| heavy = makeHeavyFootprint(footprint, MaskedImage(zeroImage, dtype=dtype)) |
There was a problem hiding this comment.
Suggested change
| heavy = makeHeavyFootprint(footprint, MaskedImage(zeroImage, dtype=dtype)) | |
| heavy = HeavyFootprintF(footprint) | |
| heavy.getImageArray()[0] = 0.0 |
is probably a bit more efficient (no need for Image or MaskedImage temporaries), but I'm not sure it's enough better to merit another Jenkins run. Just another way to do it.
There was a problem hiding this comment.
Good idea. I have to rebase the other packages anyway, so I'll make this change, rebase all of them, and just Jenkins without the ci packages.
Sometimes errors in the pipelines, like incorrect PSF modeling, can cause sources with valid scarlet models to have no flux after flux re-distribution when the footprints are being reconstructed. This commit adds a `deblend_zeroFlux` column to identify sources that have zero flux in a given band for follow-up.
fred3m
force-pushed
the
tickets/DM-43176
branch
from
6fb301e
to
bd228a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes errors in the pipelines, like incorrect PSF modeling, can cause sources with valid scarlet models to have no flux after flux re-distribution when the footprints are being reconstructed. This commit adds a
deblend_zeroFluxcolumn to identify sources that have zero flux in a given band for follow-up.