Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/dm 8108 #13

Merged
merged 2 commits into from Apr 26, 2017
Merged

Tickets/dm 8108 #13

merged 2 commits into from Apr 26, 2017

Conversation

natelust
Copy link
Contributor

No description provided.

fred3m
fred3m reviewed Apr 14, 2017
View reviewed changes
Copy link
Contributor

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, other than my preference for updating Footprint so that it can be initialized with a Point2I and width, which would create a new SpanSetfrom the Point2I and width.

I don't see a reason to pass this on to the end user.

@natelust natelust merged commit 170a3c3 into master Apr 26, 2017
@ktlim ktlim deleted the tickets/DM-8108 branch August 25, 2018 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred3m fred3m fred3m left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@natelust @fred3m