DM-30426: Use psf->computeImageBBox() #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Jun 7, 2021
jmeyers314
force-pushed
the
tickets/DM-30426
branch
2 times, most recently
from
7bd3228
to
4b0cff8
Compare
In particular, avoid inferring psf->computeImage()->getBBox() from psf->computeBBox(), since this has proven unreliable and different Psf subclasses may even perform the conversion differently.
jmeyers314
force-pushed
the
tickets/DM-30426
branch
from
4b0cff8
to
f9e9af9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, avoid inferring
psf->computeImage()->getBBox()from
psf->computeBBox(), since this has proven unreliable anddifferent Psf subclasses may even perform the conversion
differently.