DM-39390: Add edge flag to trailed sources #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag handling was missing the required boolean input and thus not working correctly. This has been fixed by adding True to all flaghandlers.
Add a check to see if the trailed source beginning or end pixels are off chip. If so, flag them. Otherwise, check if the beginning or end pixel of a trail lands on a pixel marked with an edge flag. If so, add and edge flag to those trailed sources.
bsmartradio
force-pushed
the
tickets/DM-39390
branch
4 times, most recently
from
c76b065
to
9d73213
Compare
mrawls
reviewed
Sep 25, 2023
bsmartradio
force-pushed
the
tickets/DM-39390
branch
3 times, most recently
from
47de196
to
918b188
Compare
bsmartradio
force-pushed
the
tickets/DM-39390
branch
2 times, most recently
from
5a119ac
to
b9cc125
Compare
mrawls
approved these changes
Oct 2, 2023
bsmartradio
force-pushed
the
tickets/DM-39390
branch
2 times, most recently
from
6496133
to
578c76b
Compare
Added a specific unit test that tests 2 trailed sources, one which crosses into edge pixels and one which does not.
bsmartradio
force-pushed
the
tickets/DM-39390
branch
from
eae5caa
to
32cff54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag in NaivePlugin.py to check if the trailed source extends off the image or if either the beginning or end of the trail contains edge pixels. If any of these cases are true, set
ext_trailedSources_Naive_flag_edgeto True. Additionally, added several unit tests to check the new flags.