Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-32021: Add Ra/Dec measurements to meas_extensions_trailedSources #4

Merged
merged 2 commits into from Oct 4, 2021
Merged

DM-32021: Add Ra/Dec measurements to meas_extensions_trailedSources #4

merged 2 commits into from Oct 4, 2021

Conversation

langfzac
Copy link
Collaborator

@langfzac langfzac commented Oct 4, 2021

Add Ra and Dec as measurement outputs.

Additions:

  • Explicitly looks for base_SdssShape (falling back to SafeCentroidExtractor) centroid coordinates.
  • Function to convert pixel coordinates to ra/dec
  • Unit test for conversion

@langfzac langfzac requested a review from fred3m October 4, 2021 18:42
fred3m
fred3m approved these changes Oct 4, 2021
View reviewed changes
Copy link

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@langfzac langfzac merged commit f91b6b1 into master Oct 4, 2021
@langfzac langfzac deleted the tickets/DM-32021 branch October 4, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred3m fred3m fred3m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@langfzac @fred3m