Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-30699: Add new flux measurement to meas_extensions_trailedSources #6

Merged
merged 6 commits into from Jan 13, 2022
Merged

DM-30699: Add new flux measurement to meas_extensions_trailedSources #6

merged 6 commits into from Jan 13, 2022

Conversation

langfzac
Copy link
Collaborator

@langfzac langfzac commented Jan 5, 2022 •
edited

  • Add a measurement of flux to NaivePlugin.
  • Add method that returns a model image to VereModel.
  • Update VeresPlugin to compute model over exposure cutout rather than full exposure.
  • Add utils.py for common functions. Currently holds a function to return exposure cutouts.
  • Replace instances of single letter variables (ie. L, F, etc.) with more descriptive names (length, flux, etc.).

@langfzac langfzac force-pushed the tickets/DM-30699 branch 4 times, most recently from ead2db2 to 342df41 Compare January 5, 2022 20:29
womullan
womullan reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@womullan womullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the clean up on the variable names .

womullan
womullan approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@womullan womullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, clear, enough comments, test modified.

python/lsst/meas/extensions/trailedSources/utils.py Show resolved Hide resolved
src/VeresModel.cc Outdated Show resolved Hide resolved
@langfzac langfzac merged commit 812f256 into main Jan 13, 2022
@langfzac langfzac deleted the tickets/DM-30699 branch January 13, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@womullan womullan womullan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@langfzac @womullan