Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33325: Update measurement uncertainties in meas_extensions_trailedSources #8

Merged
merged 4 commits into from May 6, 2022

Conversation

langfzac
Copy link
Collaborator

First-pass at adding uncertainties for updated NaivePlugin measurements (length, angle, flux).

  • Move flux computation to C++ layer, and adds gradient computation with respect to the other VeresModel parameters.
  • Add SAFE_CENTROID flag. (Want the SdssShape centroid, so throw flag if we fall back to safe.)
  • Move 'non-weighted' length computation to function and compute gradients of both length computations.
  • Propagate measurement uncertainties from centroid and second-moments.
  • Add tests for gradient computations
  • Add monte-carlo tests for length and angle uncertainties. For now, just make sure we're close, or at least over estimate.

Note: Flux uncertainty underestimates the monte-carlo derived values (often ~50%). This will be addressed in a future PR.

src/VeresModel.cc Show resolved Hide resolved
src/VeresModel.cc Outdated Show resolved Hide resolved
@langfzac langfzac merged commit 28a2c77 into main May 6, 2022
@langfzac langfzac deleted the tickets/DM-33325 branch May 6, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants