Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37767: use pybind wrappers, merge into one pybind shared lib #106

Merged
merged 2 commits into from Feb 13, 2023

Conversation

mwittgen
Copy link
Contributor

No description provided.

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace imports should be done selectively. Thanks!

python/lsst/meas/modelfit/_modelfitLib.cc Outdated Show resolved Hide resolved
python/lsst/meas/modelfit/cmodel/cmodel.cc Show resolved Hide resolved
python/lsst/meas/modelfit/optimizer/optimizer.cc Outdated Show resolved Hide resolved
python/lsst/meas/modelfit/pixelFitRegion/__init__.py Outdated Show resolved Hide resolved
python/lsst/meas/modelfit/priors/__init__.py Outdated Show resolved Hide resolved
python/lsst/meas/modelfit/psf/__init__.py Outdated Show resolved Hide resolved
python/lsst/meas/modelfit/optimizer/__init__.py Outdated Show resolved Hide resolved
python/lsst/meas/modelfit/cmodel/__init__.py Outdated Show resolved Hide resolved
@mwittgen
Copy link
Contributor Author

Thanks for the review. Implemented requested changes.

@mwittgen mwittgen merged commit e2851b4 into main Feb 13, 2023
@mwittgen mwittgen deleted the tickets/DM-37767 branch February 13, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants