Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37605: Relax test precision for aarch64 #109

Merged
merged 1 commit into from Sep 13, 2023
Merged

DM-37605: Relax test precision for aarch64 #109

merged 1 commit into from Sep 13, 2023

Conversation

mwittgen
Copy link
Contributor

@mwittgen mwittgen commented Sep 2, 2023

No description provided.

@mwittgen mwittgen requested a review from timj September 12, 2023 20:16
timj
timj approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know if 1E-6 is still a reasonable number. This value has not been changed since the test code was written six years ago.

@TallJimbo
Copy link
Member

I'm not bothered by 1E-6 here. Numerical derivatives are pesky unstable things, and I do know we don't need it to be better than that.

@mwittgen mwittgen merged commit d162630 into main Sep 13, 2023
2 checks passed
@mwittgen mwittgen deleted the tickets/DM-37605 branch September 13, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mwittgen @TallJimbo @timj