DM-4830: Add error flag handling to PsfFitter #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
changed the title
|
First line of commit message is too long (the first phrase is probably sufficient). |
|
|
||
| /// Initialize the fitter class with the given control object. | ||
|
|
||
| public: |
There was a problem hiding this comment.
Moving the "public" line separates the constructor from its documentation.
…thm. This class adds measure and fail to the original fitter, and also monitors the optimizer state and checks for failures. This is not a child of SimpleAlgorithm, which has a different control type. Also, the python code which exposes this algorithm can call multiple fitters in sequence, so it is really multiple algorithms. But each fitter has separate measure and fail methods, and also its own set of flags. There is nt global flag. The fitters themself fitters call fail, not the python task. Also, add unit test which tests the error flag setting. (Except for Exception)
pgee2000
force-pushed
the
tickets/DM-4830
branch
from
0d66862
to
cee9ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.