Set magnitude zero point if none exists #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,8 @@ | |||
| #ifndef LSST_MEAS_MODELFIT_UnitSystem_h_INCLUDED | |||
| #define LSST_MEAS_MODELFIT_UnitSystem_h_INCLUDED | |||
|
|
|||
| #include <math.h> | |||
There was a problem hiding this comment.
Please move this to UnitSystem.cc, and change it to #include <cmath>. The C standard libraries can be used directly from C++, but the C++ wrappers that remove the ".h" and prepend the "c" are preferred. It's not guaranteed that the stuff you include will be in std:: without that.
|
Please add a unit test. Just adding one test method to the existing test case |
This code will now check that calib objects have a valid fluxMag0 (zero-point) set. If not a default calib object is used with a reference zero-point of 27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code will now check that calib objects have a valid fluxMag0
(zero-point) set. If not a default calib object is used with a
reference zero-point of 27.