Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review for DM-5197: new shapelet PSF approximation code #21

Merged
merged 9 commits into from
May 13, 2016

Commits on May 12, 2016

  1. Allow objective functions to compute their own derivatives.

    This will eventually allow us to use analytic derivatives instead
    of finite differences.
    TallJimbo committed May 12, 2016
    Configuration menu
    Copy the full SHA
    6dc4d3a View commit details
    Browse the repository at this point in the history

Commits on May 13, 2016

  1. Rename shapelet PSF approximation algorithm and classes.

    The current algorithm is not very robust and is sometimes
    catastrophically slow.  However, it's able to fit much more general
    models than the HSC-side one we'll be adding shortly, so we'd like to
    keep it around.
    TallJimbo committed May 13, 2016
    Configuration menu
    Copy the full SHA
    d5f7773 View commit details
    Browse the repository at this point in the history
  2. Rename optimizer task config to remove collision.

    This task is slated for eventual removal, but that's more work than we
    want to do on this ticket.  For now, we just need to remove a name
    collision.
    TallJimbo committed May 13, 2016
    Configuration menu
    Copy the full SHA
    ce6da0f View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary import.

    TallJimbo committed May 13, 2016
    Configuration menu
    Copy the full SHA
    6b0844e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    072c1eb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5dff465 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e33c8ef View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c5d4e6d View commit details
    Browse the repository at this point in the history
  8. Modify floating point thresholds on new tests.

    Many of these passed on my Ubuntu box, but not
    on CentOS CI.
    TallJimbo committed May 13, 2016
    Configuration menu
    Copy the full SHA
    244dfb6 View commit details
    Browse the repository at this point in the history