DM-7358: Pytest updates #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the tests in meas_modelfit have been formatted with autopep8 to be compliant with the LSST PEP8 standard.
| class MixtureTestCase(lsst.utils.tests.TestCase): | ||
|
|
||
| @staticmethod | ||
| def makeRandomMixture(nDim, nComponents, df=float("inf")): | ||
| numpy.random.seed(500) |
There was a problem hiding this comment.
I think it would be better to put this line in a setUp method rather than duplicate it in each test.
All the tests in meas_modelfit have been modernized and made runnable under the py.test framework. Deprecated usage of assert_, assertEquals, etc... has been replaced with the appropriate modern equivalents. The random number seed setters have been moved inside the setUp method.
AstroVPK
force-pushed
the
tickets/DM-7358
branch
from
a16f01c
to
479fe95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.