DM-8357: Changes to move from pex_logging to lsst.log #36

hsinfang · 2016-12-12T22:54:39Z

review

hsinfang · 2016-12-12T22:55:24Z

src/SoftenedLinearPrior.cc

@@ -93,8 +92,8 @@ SoftenedLinearPrior::SoftenedLinearPrior(Control const & ctrl) :
            "ellipticityMaxOuter must be > 0"
        );
    }
-    pex::logging::Debug log("meas.modelfit.SoftenedLinearPrior");
-    log.debug<7>("Constructing new SoftenedLinearPrior");
+    LOG_LOGGER trace3Logger = LOG_GET("TRACE3:meas.modelfit.SoftenedLinearPrior");


. instead of :

I'm not sure where my code developed this ':' instead of the '.' I will fix it.

hsinfang · 2016-12-12T22:55:54Z

src/TruncatedGaussian.cc

@@ -75,7 +74,7 @@ TruncatedGaussian TruncatedGaussian::fromSeriesParameters(
 ) {
    static Scalar const LN_2PI = std::log(2.0*M_PI);
    static Scalar const SQRT_PI = std::sqrt(M_PI);
-    pex::logging::Debug debugLog("meas.modelfit.TruncatedGaussian");
+    LOG_LOGGER trace4Logger = LOG_GET("TRACE4:meas.modelfit.TruncatedGaussian");


. instead of :

hsinfang · 2016-12-12T22:56:20Z

src/TruncatedGaussian.cc

@@ -191,7 +190,7 @@ TruncatedGaussian TruncatedGaussian::fromStandardParameters(
    Vector const & mean, Matrix const & covariance
 ) {
    static Scalar const LN_2PI = std::log(2.0*M_PI);
-    pex::logging::Debug debugLog("meas.modelfit.TruncatedGaussian");
+    LOG_LOGGER trace4Logger = LOG_GET("TRACE4:meas.modelfit.TruncatedGaussian");


. instead of :

hsinfang · 2016-12-12T22:56:39Z

src/integrals.cc

@@ -38,8 +37,8 @@ double phid(double z) {
 }

 double bvnu(double h, double k, double rho) {
-    pex::logging::Debug log("meas.modelfit.integrals");
-    log.debug<8>("Starting bvnu: h=%g, k=%g, rho=%g", h, k, rho);
+    LOG_LOGGER trace4Logger = LOG_GET("TRACE4:meas.modelfit.integrals");


. instead of :

hsinfang · 2016-12-12T23:05:00Z

src/optimizer.cc

-    pex::logging::Debug log("meas.modelfit.optimizer.solveTrustRegion");
+    LOG_LOGGER trace5Logger = LOG_GET("TRACE5.meas.modelfit.optimizer.Optimizer");
+    LOG_LOGGER trace3Logger = LOG_GET("TRACE3.meas.modelfit.optimizer.Optimizer");
+    //


This empty line is not needed

Change the use of the debug<n> macros to instead use a traceLogger Replace the existing log objects with lsst.log.Log.getLogger(component) Change build dependences to lsst.log C++ logging uses lsst.log in place of pex logging for trace levels debuggin: Trace5 = debug<10> Trace4 = debug<8> Trace4 = debug<7> From python, lsst.log.utils.traceSetAt() is used to control trace enabling. traceSetAt(n) n=5,4,3 to be equivalent to setting Debug to 10,8,7 traceSetAt(-1) disables all traces.

hsinfang commented Dec 12, 2016

View reviewed changes

pgee2000 force-pushed the tickets/DM-8357 branch from 3464602 to cc16a3a Compare December 13, 2016 00:15

pgee2000 merged commit cc16a3a into master Dec 13, 2016

ktlim deleted the tickets/DM-8357 branch August 25, 2018 05:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DM-8357: Changes to move from pex_logging to lsst.log #36

DM-8357: Changes to move from pex_logging to lsst.log #36

hsinfang commented Dec 12, 2016

hsinfang Dec 12, 2016

pgee2000 Dec 13, 2016

hsinfang Dec 12, 2016

pgee2000 Dec 13, 2016

hsinfang Dec 12, 2016

pgee2000 Dec 13, 2016

hsinfang Dec 12, 2016

pgee2000 Dec 13, 2016

hsinfang Dec 12, 2016

pgee2000 Dec 13, 2016

DM-8357: Changes to move from pex_logging to lsst.log #36

DM-8357: Changes to move from pex_logging to lsst.log #36

Conversation

hsinfang commented Dec 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment