DM-10765: Replace existing WCS classes with SkyWcs #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-10765
branch
from
e93e95d
to
0db444d
Compare
rearmstr
reviewed
Jan 10, 2018
| @@ -34,8 +34,8 @@ namespace lsst { namespace meas { namespace modelfit { namespace detail { | |||
| * vectors evaluates the polynomial (or computes a derivative). | |||
| */ | |||
| template <int N> | |||
| struct Vandermonde { | |||
There was a problem hiding this comment.
This doesn't seem to belong to this commit.
There was a problem hiding this comment.
Good point. I made it a separate commit with a suitable commit message
rearmstr
approved these changes
Jan 17, 2018
r-owen
force-pushed
the
tickets/DM-10765
branch
from
0db444d
to
5734c0d
Compare
Vandermonde was treated as a class in one bit of code but defined as a struct. I made it a class in hopes of staving off future such warnings.
instead of sky position. That saves a call to SkyWcs.skyToPixel and should speed up some code.
r-owen
force-pushed
the
tickets/DM-10765
branch
from
5734c0d
to
2ee08a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.