DM-11162: Replace all use of Coord and subclasses with SpherePoint #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rearmstr
reviewed
Mar 22, 2018
| @@ -48,9 +49,9 @@ struct UnitSystem { | |||
| * set such that unit flux is the given magnitude. See @ref modelfitUnits for an explanation | |||
| * of why we frequently use this system. | |||
| */ | |||
| UnitSystem(afw::coord::IcrsCoord const & position, std::shared_ptr<const lsst::afw::image::Calib> calibIn, | |||
| UnitSystem(afw::geom::SpherePoint const& position, std::shared_ptr<const lsst::afw::image::Calib> calibIn, | |||
There was a problem hiding this comment.
clang-format; I can make it a separate commit if you want
There was a problem hiding this comment.
My concern was for consistency in the file/package. Did it flag the other cases in this file?
There was a problem hiding this comment.
I can run clang-format on the whole file if you prefer. Normally I only run it on code I change.
Note that the output of clang-format is always acceptable; we'd go mad otherwise.
There was a problem hiding this comment.
I prefer to keep the same style within a file, but I'm happy to be overruled if this is not what others want.
There was a problem hiding this comment.
Fair enough. I'll run clang-format as a separate commit.
as per reviewer request for internal consistency in the placement of & and a desire to use clang-format to format my new code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.