tickets/DM-16384 #72
Merged
tickets/DM-16384 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Oct 31, 2018
python/lsst/meas/modelfit/mixture.cc
Outdated
| (void (Mixture::*)(ndarray::Array<Scalar const, 1, 1> const &, | ||
| ndarray::Array<Scalar,1,1> const &, | ||
| ndarray::Array<Scalar,2,1> const &) const) | ||
| &Mixture::evaluateDerivatives, "x"_a, "gradient"_a, "hessian"_a); |
There was a problem hiding this comment.
Should use py::overload_cast instead.
| hessian.deep() = 0.0; | ||
| gradient.setZero(); | ||
|
|
||
| if (computeHessian) { |
There was a problem hiding this comment.
Might want to add an assert(hessian) here if internal logic is supposed to guarantee that it's always nonnull when computeHessian is true, or an exception-throwing check if there's no internal guarantee on that.
include/lsst/meas/modelfit/Mixture.h
Outdated
| void evaluateDerivativesImpl(A const & x, | ||
| B & gradient, | ||
| C * hessian, | ||
| bool computeHessian = true) const; |
There was a problem hiding this comment.
Might want to start this with an underscores (we aren't universally consistent about whether to do that on all private methods, but we do seem to be doing it in other methods in this class).
Add Eigen interfaces to some Mixure methods in addition to ndarray interfaces
natelust
force-pushed
the
tickets/DM-16384
branch
from
9929c80
to
0ec9d1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Mixure api to use Eigen
Add Eigen interfaces to some Mixure methods in addition to ndarray
interfaces