Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-20566: Switch from afw.geom to geom #82

Merged
merged 5 commits into from Jul 18, 2019
Merged

DM-20566: Switch from afw.geom to geom #82

merged 5 commits into from Jul 18, 2019

Conversation

timj
Copy link
Member

@timj timj commented Jul 17, 2019

No description provided.

timj added 5 commits July 17, 2019 12:47
@timj
Fix name of test file
afce4d2 
This was renamed two years ago but the .py was dropped so
pytest was not running any of the tests in it.
@timj
Clean up some cruft in tests
d25f1e6 
* Properly skip scipy
* Remove unused imports
@timj
Switch tests from afwGeom to geom where appropriate
1893e8a
@timj
Switch C++ from afwGeom to geom where appropriate
568a1ee
@timj
Formally depend on geom
94a647b
@timj timj requested a review from isullivan July 18, 2019 20:28
isullivan
isullivan approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@timj timj merged commit 000ad9a into master Jul 18, 2019
@timj timj deleted the tickets/DM-20566-meas_modelfit branch July 18, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timj @isullivan