DM-39146: Memory efficiency for rbTransiNetTask/Interface #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NimSed
commented
May 11, 2023
NimSed
commented
- Use batches in rbTransiNetInterface.
- Test batches, rename test methods and classes.
- Add minor logging to rbTransiNetTask
ebellm
approved these changes
May 11, 2023
| batches : `list` [`list` [`CutoutInputs`]] | ||
| List of batches of inputs. | ||
| """ | ||
| batches = [inputs[i:i + batchSize] for i in range(0, len(inputs), batchSize)] |
There was a problem hiding this comment.
For even better memory efficiency you might make this a generator
There was a problem hiding this comment.
Good point. See if it looks better now.
ebellm
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.