DM-35540: Make the real-bogus Task and Interface run and pass the existing tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Jul 12, 2022
parejkoj
approved these changes
Jul 13, 2022
| inputs = CutoutInputs(science=data, difference=data, template=data) | ||
| result = self.interface.infer([inputs]) | ||
| # TODO: I think this should return a score of identically zero? | ||
| self.assertEqual(result, [0]) | ||
| self.assertTupleEqual(result.shape, (1, 1)) # Result is an array, even if we pass a signle sample |
tests/test_TransiNetInterface.py
Outdated
| # TODO: I think this should return a score of identically zero? | ||
| self.assertEqual(result, [0]) | ||
| self.assertTupleEqual(result.shape, (1, 1)) # Result is an array, even if we pass a signle sample | ||
| self.assertAlmostEqual(result[0][0], 0.5011908) |
There was a problem hiding this comment.
Let's note that this is a purely empirical value.
Now checks against an empirical (but meaningless) value, as well as the size of the returned array. Note: this assumes a fixed model+checkpoint file, which may change in the future.
It is also squeezed to prevent the checkpoint from growing too big. Updated checkpoint uploaded too.
parejkoj
pushed a commit
that referenced
this pull request
Dec 24, 2022
DM-35540: Make the real-bogus Task and Interface run and pass the existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is just about making the code not fail. Has nothing to do with the real-bogus classification accuracy, etc.